https://bugzilla.redhat.com/show_bug.cgi?id=1342743 --- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Ben Rosser from comment #2) > Sorry for the delay in getting to this one. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > > - There are unit tests available, is it feasible to run them? See here: > https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/testing.txt > It may not be, though, because it seems you need to compile with some > debugging options set. It's for debugging only. > > - According to licensecheck, there are also sources under the MIT license... > some of these aren't used (e.g. MSVC/include/dirent.h), but json.cc and > worley.cc seem to get built. So you should add "and MIT" to the license > field. > > crawl-0.18.1/crawl-ref/crawl-tiles/MSVC/include/dirent.h > crawl-0.18.1/crawl-ref/crawl-tiles/json.cc > crawl-0.18.1/crawl-ref/crawl-tiles/json.h > crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery. > cookie.js > crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery. > tablesorter.js > crawl-0.18.1/crawl-ref/crawl-tiles/worley.cc > crawl-0.18.1/crawl-ref/crawl-tiles/worley.h > crawl-0.18.1/crawl-ref/source/MSVC/include/dirent.h > crawl-0.18.1/crawl-ref/source/json.cc > crawl-0.18.1/crawl-ref/source/json.h > crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery.cookie. > js > crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery. > tablesorter.js > crawl-0.18.1/crawl-ref/source/worley.cc > crawl-0.18.1/crawl-ref/source/worley.h Okay, fixed. > > fedora-review automatically generated the following issues, but they appear > to both be spurious, so I would ignore them: > > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > (my comment: this isn't actually an issue, the guidelines have been reworded > relatively recently to *not* say that you should assume a compiler is > installed. So this isn't something I'd worry about). > > - gtk-update-icon-cache is invoked in %postun and %posttrans if package > contains icons. > Note: icons in crawl-common-data > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > (my comment: they... are, I don't know what fedora-review is talking about > here). > 'gtk-update-icon-cache' must be invoked for crawl-common-data sub-package that provides all icons. Fixed. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00338976-crawl/crawl-0.18.1-4.fc25.src.rpm - Include MIT license - Fix scriptlets for icons -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx