Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fbset https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225744 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora adrian@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrian@xxxxxxxx Flag| |fedora-review? ------- Additional Comments From adrian@xxxxxxxx 2007-06-29 08:27 EST ------- This looks pretty much like it can be closed. There are four little points we should be changed: * change buildroot to be guidelines compliant * add comment why %{?_smp_mflags} cannot be used * add comment why make install DESTDIR=%{buildroot} cannot be used * add noreplace to the config (to silence rpmlint) --- fbset.spec 18 Jan 2007 15:37:11 -0000 1.21 +++ fbset.spec 29 Jun 2007 12:24:40 -0000 @@ -10,7 +10,7 @@ Patch0: fbset-2.1-makefile.patch Patch1: fbset-2.1-fixmode.patch Patch2: fbset-2.1-manfix.patch -BuildRoot: %{_tmppath}/%{name}-root +BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) ExcludeArch: s390 s390x %description @@ -27,11 +27,13 @@ %patch2 -p1 -b .man %build +# %{?_smp_mflags} breaks building make CFLAGS="$RPM_OPT_FLAGS" %install rm -rf ${RPM_BUILD_ROOT} +# make install DESTDIR=%{buildroot} does not work here %makeinstall %clean @@ -41,7 +43,7 @@ %defattr(-,root,root) %{_sbindir}/* %{_mandir}/man[58]/* -%config %{_sysconfdir}/fb.modes +%config(noreplace) %{_sysconfdir}/fb.modes %changelog * Thu Jan 18 2007 Jindrich Novy <jnovy@xxxxxxxxxx> - 2.1-24 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review