[Bug 1338505] Review Request: planex - RPM build tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1338505



--- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
Planex use yum-plugin-priorities - note that new projects should not use yum,
but rather DNF. And this plugin is now part of DNF, see priority option in man
dnf.conf.

There are no man pages:
planex.noarch: W: no-manual-page-for-binary planex-fetch
planex.noarch: W: no-manual-page-for-binary planex-init
planex.noarch: W: no-manual-page-for-binary planex-depend
planex.noarch: W: no-manual-page-for-binary planex-makedeb
planex.noarch: W: no-manual-page-for-binary planex-cache
planex.noarch: W: no-manual-page-for-binary planex-pin

> sed -i "s/\(version='\)[^'\"]\+/\1%{version}-%{release}/g" setup.py
Why? This is not needed. Version is version. Not version-release.

> %{__python} setup.py build
Should be:
  %py2_build

> %{__python} setup.py install --single-version-externally-managed -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES
Should be:
  %py2_install

> Requires: createrepo
Createrepo is obsolete. You should use createrepo_c. It is much faster and is
usually drop-in replacement.
http://portingdb-encukou.rhcloud.com/pkg/createrepo/

This package use python2. Whole Fedora is now trying to migrate to Python3
  http://portingdb-encukou.rhcloud.com/
It will be nice if you can cooperate with upstream on migrating to python3.

Any reason why planex.ps is not included as %doc?

Upstream provides tests and you do not run them in %check section. You should
run it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]