https://bugzilla.redhat.com/show_bug.cgi?id=1218758 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(hobbes1069@gmail. | |com) | |needinfo?(hobbes1069@gmail. | |com) | --- Comment #21 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Sorry, I just got back from my son's summer camp. (In reply to Eric Christensen from comment #19) > I'm a little concerned about the missing-call-to-setgroups-before-setuid > error that rpmlint is giving. Also, the COPYING is GPLv2 and SPEC says > GPLv3. As noted in comment #14, this is part of the bundled mongoose but flmsg doesn't make use of it so it shouldn't be a problem. I dug into the license stuff a bit. I'll follow up with the author but yet, the COPYING file should probably be updated to GPLv3+. The GPLv2 stuff is just the mongoose files, since it's not "+" I can't upgrade them to 3+ so I'll add an appropriate statement to the spec file and license tag. The BSD stuff is part of the build system files so it doesn't apply to the package. > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 There was an update to the packaging guidelines to add this as they are working on lowing the number default packages installed for mock. Granted I saw this on an email update but haven't looked at the guidelines in the wiki lately... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx