Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ndesk-dbus - Managed DBus implementation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245491 peter@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2007-06-28 23:12 EST ------- Here we go.... a formal review of ndesk-dbus 0.5.2-3: OK: Source matches that of upstream: $ md5sum dbus-sharp-0.5.2*.tar.gz 86312f99721a97dc8028343d477fd4be dbus-sharp-0.5.2-srpm.tar.gz 86312f99721a97dc8028343d477fd4be dbus-sharp-0.5.2-upstream.tar.gz. OK: Package naming is good; and the BuildRoot is sane. OK: Package license (MIT) is acceptable for Fedora and matches that of upstream; and a copy of this is included in the package as %doc (COPYING). OK: -devel subpackage properly requires pkgconfig since it installs a .pc file. OK: Package builds fine in mock (F-7, x86_64); though it fails in Devel (see below). OK: Spec file is legible and in American English. OK: Final file and directory ownership looks good; and the %files listing contains no duplicates. OK: The buildroot is cleaned before anything else is done in %install; and a proper %clean section is used. OK: Macros are consistent; though the choice was made to use $RPM_foo variables instead of their respective %foo definitions (entirely aesthetic). OK: Package contains permissible code. OK: Files marked as documentation (%doc) do not affect runtime capabilites. OK: Package contains no libtool files (*.la). OK: All files and their names are proper UTF-8. N/A: This package does not install locale data; so %find_lang handling is not needed. N/A: This package does not install shared libraries; so ldconfig invocations in %post/%postun are not necessary. N/A: A separate -doc subpackage is not required since this installs very little documentation. N/A: Package is not a GUI application; so no .desktop magic is needed. N/A: Scriptlets are not used. -- BAD --- (1) rpmlint output: > W: ndesk-dbus summary-not-capitalized ndesk-dbus is a C# implementation of D-Bus. > W: ndesk-dbus summary-ended-with-dot ndesk-dbus is a C# implementation of D-Bus. > W: ndesk-dbus-devel summary-not-capitalized ndesk-dbus is a C# implementation of D-Bus. > W: ndesk-dbus-devel summary-ended-with-dot ndesk-dbus is a C# implementation of D-Bus. These are aesthetic; but your Summary should not end in a period ("."); and it also should not need the "ndesk-dbus is..." prefixing phrase. > W: ndesk-dbus obsolete-not-provided dbus-sharp If it is a true replacement for the old libdbus wrapper, please add a "Provides: dbus-sharp" along with the Obsoletes tag. > E: ndesk-dbus only-non-binary-in-usr-lib Since it installs files to %_libdir, it should not be a noarch package. (Then again, I'm not too familiar with how Mono handles this. Input from someone who is would be greatly appreciated. ^_^) > W: ndesk-dbus-devel no-documentation It might be wise to add COPYING as the sole %doc file in this subpackage; but this is otherwise harmless. (2) Development subpackages (*-devel) should have a full EVR for the base dependency; E.g., change the dependency to Requires: %{name} = %{version}-%{release}. (3) This fails to build in Mock in Development. Adding mono-core to the BuildRequires appears to fix it. make -C src make[1]: Entering directory `/builddir/build/BUILD/dbus-sharp-0.5.2/src' gmcs -debug -unsafe -d:STRONG_NAME -out:NDesk.DBus.dll -t:library -r:Mono.Posix -keyfile:../ndesk.snk Address.cs AssemblyInfo.cs Bus.cs BusObject.cs Connection.cs ExportObject.cs Authentication.cs Protocol.cs Mapper.cs MatchRule.cs Message.cs MessageFilter.cs MessageReader.cs MessageWriter.cs PendingCall.cs SocketTransport.cs Transport.cs TypeImplementer.cs Wrapper.cs UnixTransport.cs UnixNativeTransport.cs DBus.cs Introspection.cs DProxy.cs Signature.cs make[1]: gmcs: Command not found make[1]: *** [NDesk.DBus.dll] Error 127 make[1]: Leaving directory `/builddir/build/BUILD/dbus-sharp-0.5.2/src' make: *** [all] Error 2 $ rpm -qf `which gmcs` mono-core-1.2.4-1.fc8 (4) Your %setup invocation should be quieter: Use the "-q" option. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review