https://bugzilla.redhat.com/show_bug.cgi?id=1342747 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Limnoria - |Review Request: limnoria - |A modified version of |A modified version of |Supybot (an IRC bot) with |Supybot (an IRC bot) with |enhancements and bug fixes |enhancements and bug fixes --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> --- > - Licensing is both MIT/BSD and GPLv2 and GPLv2+, latter two are missing in spec file and in %license. Fixed and added more info in comment: License: BSD and GPLv2 and GPLv2+ # # The bulk of the package is BSD. # Parts of the Math plugin are GPLv2+ # The Dict plugin is GPLv2+ # > - Missing Requires for all python libraries needed Added. > - %install runs rm -rf $RPM_BUILD_ROOT Removed. > [!]: Package is named according to the Package Naming Guidelines. Note: guidelines: "Package names should be in lower case ..." Is there a specific reason not to follow this? Upstream is using a cap L, and I provided a lowercase provide, but I am happy to switch it to the other way. It seems debian also uses lowercase, so would be good to follow them. New spec/SRPM: Spec URL: http://www.scrye.com/~kevin/fedora/review/Limnoria/limnoria.spec SRPM URL: http://www.scrye.com/~kevin/fedora/review/Limnoria/limnoria-20160506-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx