[Bug 1328951] Review Request: commissaire-client - CLI for Commissaire

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1328951



--- Comment #4 from Matthew Barnes <mbarnes@xxxxxxxxxx> ---
(In reply to William Moreno from comment #3)
> - Does this package requires commissaire at runtime or can work with remote
> hosts?

commctl talks to commissaire over HTTP so no direct dependency.

I switched commctl to python3 and fixed the package version.

----

SRPM URL:
https://mbarnes.fedorapeople.org/commissaire/commissaire-client-0.0.1-0.3.rc3.fc23.src.rpm

Spec diff:

@@ -1,24 +1,26 @@
+%global prerelease rc3
+
 Name:           commissaire-client
-Version:        0.0.1rc3
-Release:        2%{?dist}
+Version:        0.0.1
+Release:        0.3.%{prerelease}%{?dist}
 Summary:        CLI for Commissaire
 License:        LGPLv2+
 URL:            http://github.com/projectatomic/commctl
-Source0:       
https://github.com/projectatomic/commctl/archive/%{version}.tar.gz
+Source0:       
https://github.com/projectatomic/commctl/archive/%{version}%{prerelease}.tar.gz

 BuildArch:      noarch

-BuildRequires:  python-devel
+BuildRequires:  python3-devel

 # For tests
-BuildRequires:  python-coverage
-BuildRequires:  python-mock
-BuildRequires:  python-nose
-BuildRequires:  python-flake8
-
-Requires:       python-setuptools
-Requires:       py-bcrypt
-Requires:       PyYAML
+BuildRequires:  python3-coverage
+BuildRequires:  python3-mock
+BuildRequires:  python3-nose
+BuildRequires:  python3-flake8
+
+Requires:       python3-setuptools
+Requires:       python3-py-bcrypt
+Requires:       python3-PyYAML

 Provides:       commctl

@@ -26,18 +28,18 @@ Provides:       commctl
 Command line tools for Commissaire.

 %prep
-%autosetup -n commctl-%{version}
+%autosetup -n commctl-%{version}%{prerelease}


 %build
-%py2_build
+%py3_build

 %install
-%py2_install
+%py3_install

 %check
 # XXX: Issue with the coverage module.
-#%{__python2} setup.py nosetests
+#%{__python3} setup.py nosetests


 %files
@@ -46,10 +48,15 @@ Command line tools for Commissaire.
 %doc CONTRIBUTORS
 %doc MAINTAINERS
 %{_bindir}/commctl
-%{python2_sitelib}/*
+%{python3_sitelib}/*


 %changelog
+* Mon Jun 06 2016 Matthew Barnes <mbarnes@xxxxxxxxxx> - 0.0.1-0.3.rc3
+- Switch to python3.
+- Move pre-release indicator ('rc3') to Release tag for compliance with
+  packaging guidelines.
+
 * Thu Jun 02 2016 Matthew Barnes <mbarnes@xxxxxxxxxx> - 0.0.1rc3-2
 - Add Provides: commctl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]