https://bugzilla.redhat.com/show_bug.cgi?id=1202295 --- Comment #7 from Luke Macken <lmacken@xxxxxxxxxx> --- (In reply to John Dulaney from comment #6) > A few rpmlint issues: > > xonsh.noarch: E: non-executable-script > /usr/lib/python3.4/site-packages/xonsh/xoreutils/_which.py 644 /usr/bin/env > xonsh.noarch: E: script-without-shebang > /usr/lib/python3.4/site-packages/xontrib/pyselect.xsh > xonsh.noarch: W: no-manual-page-for-binary xonsh > > > Also, the separate spec file is different from that in the srpm: > > [jdulaney@bodrog review]$ diff -u xonsh.spec ../rpmbuild/SPECS/xonsh.spec > --- xonsh.spec 2016-06-04 21:25:06.000000000 +0000 > +++ ../rpmbuild/SPECS/xonsh.spec 2016-06-04 21:08:36.000000000 +0000 > @@ -9,6 +9,9 @@ > License: BSD > URL: https://github.com/scopatz/xonsh > Source0: > https://pypi.python.org/packages/source/x/%{pypi_name}/%{pypi_name}- > %{version}.tar.gz > +# It may look nice but the logo is just redudant spam > +# in build process > +#Patch0: 001-remove-logo-from-setup.patch > BuildArch: noarch > > BuildRequires: python3-devel > > You may want to change the url to the new pypi.io. > > > > Also, not sure if we should consider the old review abandoned or not; if so, > I think the procedure is to close this one and start a fresh review. Updated: https://lmacken.fedorapeople.org/rpms/xonsh-0.3.2-1.fc23.src.rpm https://lmacken.fedorapeople.org/rpms/xonsh.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx