[Bug 1338140] Review Request: guayadeque - Music player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #15 from MartinKG <mgansser@xxxxxxxx> ---
(In reply to Raphael Groner from comment #12)

> > [?]: Package contains no bundled libraries without FPC exception.
> > => Source files without license header, see above.
> 
> Licensecheck script fails to detect the header, we overlooked that in first
> run. SHOULD ask upstream why wxCurl is bundled and try to unbundle.
> https://github.com/anonbeat/guayadeque/issues/8#issuecomment-222497195
> https://sourceforge.net/projects/wxcurl/

the packaging of wxcurl is currently discussed on the FedoraForum:
http://forums.fedoraforum.org/showthread.php?t=310141

need more assistance !


> Subpackages for locales look nearly good (ignore the rpmlint warnings),
> except:
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/guayadeque,
>      /usr/share/locale/sr_latin, /usr/share/locale/sr_latin/LC_MESSAGES
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners:
>      /usr/share/locale/sr_latin/LC_MESSAGES, /usr/share/locale/sr_latin,
>      /usr/share/guayadeque
> => Fix with:
> %files
> %dir %{_datadir}/%{name}
> 
done

> guayadeque-langpack-sr_latin.noarch: E: incorrect-locale-subdir
> /usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
> guayadeque-langpack-sr_latin.noarch: E: invalid-lc-messages-dir
> /usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
> => sr_latin is not a valid locale identifier, change to sr@latin.
> https://github.com/anonbeat/guayadeque/issues/6
>
done

new rpm package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/guayadeque.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/guayadeque-0.4.1-0.6.beta1git79b6383.fc24.src.rpm

%changelog
* Sat Jun 04 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> -
0.4.1-0.6.beta1git79b6383
- Update to 0.4.1-0.6.beta1git79b6383
- Added wxWidgets to License tag
- Added %%dir %%{_datadir}/%%{name} because it's owned by the package
- modified macro for l10n subpackage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]