Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gearman - Distributed job system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245655 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-28 18:36 EST ------- rpmlint has this to say: E: perl-Gearman useless-explicit-provides perl(Gearman::Client) which unfortunately means you have a dependency to filter out. The URL seems invalid; at least I get a 404 when attempting to download it. http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Gearman-1.08.tar.gz seems to work for me. I can find no license statement of any kind in the code, documentation or upstream web page. How did you determine that "GPL or Artistic" applies? Review: * source files match upstream: bf4fe03657e49cd5109be54d43158d8e3979329f11f1c7de4420b9d4afc1a8b7 Gearman-1.08.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. ? license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly X rpmlint has a valid complaint. X final provides and requires are sane: perl(Gearman::Client) perl(Gearman::Client) = 1.08 perl(Gearman::Job) perl(Gearman::JobStatus) perl(Gearman::Objects) perl(Gearman::ResponseParser) perl(Gearman::ResponseParser::Taskset) perl(Gearman::Task) perl(Gearman::Taskset) perl(Gearman::Util) perl(Gearman::Worker) perl-Gearman = 1.08-1.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Gearman::Client) perl(Gearman::JobStatus) perl(Gearman::Objects) perl(Gearman::ResponseParser::Taskset) perl(Gearman::Task) perl(Gearman::Taskset) perl(Gearman::Util) perl(IO::Socket::INET) perl(Scalar::Util) perl(Socket) perl(String::CRC32) perl(Time::HiRes) perl(base) perl(fields) perl(strict) * %check is present and all runnable tests pass, but not many of them run because they require a running server to test against. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review