[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats ( required for `samtools`)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1326504



--- Comment #7 from Dave Love <d.love@xxxxxxxxxxxxxxx> ---
(In reply to Sam Nicholls from comment #6)
> Could you describe the issue with the source URL
> (https://github.com/samtools/htslib/releases/download/1.3.1/htslib-1.3.1.tar.
> bz2 works for me, for example).

I don't know what I saw at the tine, but now I see from rpmlint:

htslib.spec: W: invalid-url Source0:
https://github.com/samtools/htslib/releases/download/1.3.1/htslib-1.3.1.tar.bz2
HTTP Error 403: Forbidden

I don't know why, since that URL does work with wget, and don't have time to
debug it.

> With regards to bzip2/lzma, I was under the impression the support is a
> little shaky at this time (see
> https://github.com/samtools/htslib/blob/develop/Makefile#L36-38) but support
> is optional, not required, for CRAM.

Fair enough, but worth a comment in the spec.

The changelog is garbled.  You should use rpmlint, or preferably fedora-review
(which includes rpmlint) which the package has basically to pass anyhow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]