https://bugzilla.redhat.com/show_bug.cgi?id=1341815 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thanks for the review, William. Let me know if I can review something for you. (In reply to William Moreno from comment #1) > - Binary eggs must be removed in %prep > Note: Binary egg files not removed in %prep: > ./python2/src/zope/testrunner/tests/testrunner- > ex-251759/eggs/foo.bar-1.2-py2.5.egg ./python3/src/zope/testrunner/tests > /testrunner-ex-251759/eggs/foo.bar-1.2-py2.5.egg That's not a real egg. It's part of an example (hence the foo.bar name), but rpmlint can't tell that. Sorry, I intended to mention this when I filed the review bug, but managed to forget. :-( > - Please chech the ownership of this directories: I thought this package should own that dir, too, because I didn't think it had any dependencies on packages that owned it, but I see python-zope-exceptions in the list. I will remove ownership of that directory. > - Please fix those rpmlint issues: I don't know what to do about the zero length files. They are part of the distribution, and are listed in SOURCES.txt, so I'm reluctant to delete them. As for the man page, I will use help2man to generate man pages. New URLs: Spec URL: https://jjames.fedorapeople.org/python-zope-testrunner/python-zope-testrunner.spec SRPM URL: https://jjames.fedorapeople.org/python-zope-testrunner/python-zope-testrunner-4.5.0-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx