[Bug 1338140] Review Request: guayadeque - Music player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #12 from Raphael Groner <projects.rg@xxxxxxxx> ---
> [!]: If the package is under multiple licenses, the licensing breakdown
>      must be documented in the spec.

Please do so. That's MUST.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

wxCurl has wxWidgets Library License (two files in src/curl and two files in
src/wx/curl), so append wxWidgets as short name to License tag.
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses


> [?]: Package contains no bundled libraries without FPC exception.
> => Source files without license header, see above.

Licensecheck script fails to detect the header, we overlooked that in first
run. SHOULD ask upstream why wxCurl is bundled and try to unbundle.
https://github.com/anonbeat/guayadeque/issues/8#issuecomment-222497195
https://sourceforge.net/projects/wxcurl/


Subpackages for locales look nearly good (ignore the rpmlint warnings), except:
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/guayadeque,
     /usr/share/locale/sr_latin, /usr/share/locale/sr_latin/LC_MESSAGES
[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/locale/sr_latin/LC_MESSAGES, /usr/share/locale/sr_latin,
     /usr/share/guayadeque
=> Fix with:
%files
%dir %{_datadir}/%{name}

guayadeque-langpack-sr_latin.noarch: E: incorrect-locale-subdir
/usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
guayadeque-langpack-sr_latin.noarch: E: invalid-lc-messages-dir
/usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
=> sr_latin is not a valid locale identifier, change to sr@latin.
https://github.com/anonbeat/guayadeque/issues/6


(Sorry for the delay of my response, I'm quite busy currently.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]