https://bugzilla.redhat.com/show_bug.cgi?id=1089962 --- Comment #23 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to gil cattaneo from comment #21) > Issues: > non blocking > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "GPL (v3)", "GPL (v2 or later)", "Unknown or generated". 8 > files have unknown license. Detailed output of licensecheck in > /home/gil/1089962-radeontop/licensecheck.txt > File without license header: > radeontop-2047d134262b4e9e3514718edc01c27b0ed86352/familycheck.sh > radeontop-2047d134262b4e9e3514718edc01c27b0ed86352/getamdgpuids.sh > radeontop-2047d134262b4e9e3514718edc01c27b0ed86352/getver.sh > > radeontop-2047d134262b4e9e3514718edc01c27b0ed86352/include/r600_pci_ids.h > > Please, ask to upstream to confirm the licensing of code and/or content/s > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification Already asked upstream for clarification. It could be likely generated. https://github.com/clbr/radeontop/issues/31 > > blocking > [!]: Changelog in prescribed format. > radeontop.i686: W: incoherent-version-in-changelog 0.9-1.git20160527.2047d13 > ['0.9-1.20160527git2047d13.fc25', '0.9-1.20160527git2047d13'] Fixed. > Other issues: remove Group field is useless and not correct Good catch. now removed. Here is the updated files: SPEC: https://luya.fedorapeople.org/packages/SPECS/radeontop.spec SRPMS: https://luya.fedorapeople.org/packages/SRPMS/radeontop-0.9-2.20160527git2047d13.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx