https://bugzilla.redhat.com/show_bug.cgi?id=1339158 Ben Rosser <rosser.bjr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Great, looks good to me! This package is approved! Full review follows: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* Public domain", "zlib/libpng", "GPL (v2)". 801 files have unknown license. Detailed output of licensecheck in /home/bjr/Programming/fedora/1339158-pioneer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/40x40(gpodder, VirtualBox), /usr/share/icons/hicolor/40x40/apps(gpodder, VirtualBox) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in pioneer [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 143360 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pioneer- data , pioneer-doc , pioneer-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1218560 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pioneer-20160512-3.fc25.x86_64.rpm pioneer-data-20160512-3.fc25.noarch.rpm pioneer-doc-20160512-3.fc25.noarch.rpm pioneer-debuginfo-20160512-3.fc25.x86_64.rpm pioneer-20160512-3.fc25.src.rpm pioneer.x86_64: W: no-documentation pioneer.x86_64: W: no-manual-page-for-binary pioneer pioneer.x86_64: W: no-manual-page-for-binary modelcompiler pioneer.x86_64: W: desktopfile-without-binary /usr/share/applications/pioneer.desktop env pioneer-data.noarch: W: dangling-symlink /usr/share/pioneer/fonts/DejaVuSansMono.ttf /usr/share/fonts/dejavu/DejaVuSansMono.ttf pioneer-data.noarch: W: dangling-symlink /usr/share/pioneer/fonts/Orbiteer-Bold.ttf /usr/share/fonts/pioneer/Orbiteer-Bold.ttf pioneer-data.noarch: W: dangling-symlink /usr/share/pioneer/fonts/PionilliumText22L-Medium.ttf /usr/share/fonts/pioneer/PionilliumText22L-Medium.ttf pioneer-data.noarch: W: dangling-symlink /usr/share/pioneer/fonts/Inpionata.ttf /usr/share/fonts/pioneer/Inpionata.ttf pioneer-data.noarch: W: dangling-symlink /usr/share/pioneer/fonts/wqy-microhei.ttc /usr/share/fonts/wqy-microhei/wqy-microhei.ttc pioneer-data.noarch: W: dangling-symlink /usr/share/pioneer/fonts/DejaVuSans.ttf /usr/share/fonts/dejavu/DejaVuSans.ttf pioneer-doc.noarch: W: spelling-error %description -l en_US Lua -> Lu, La, Luna pioneer-doc.noarch: W: file-not-utf8 /usr/share/doc/pioneer-doc/codedoc/javascript/prettify.js pioneer-doc.noarch: W: file-not-utf8 /usr/share/doc/pioneer-doc/codedoc/styles/1.css pioneer-doc.noarch: W: file-not-utf8 /usr/share/doc/pioneer-doc/codedoc/javascript/main.js 5 packages and 0 specfiles checked; 0 errors, 14 warnings. Requires -------- pioneer (rpmlib, GLIBC filtered): /bin/sh graphviz hicolor-icon-theme libGL.so.1()(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_image-2.0.so.0()(64bit) libassimp.so.3()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) librt.so.1()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libvorbisfile.so.3()(64bit) libz.so.1()(64bit) pioneer-data rtld(GNU_HASH) pioneer-data (rpmlib, GLIBC filtered): dejavu-sans-fonts dejavu-sans-mono-fonts pioneer-inpionata-fonts pioneer-orbiteer-bold-fonts pioneer-pionilliumtext22l-medium-fonts wqy-microhei-fonts pioneer-doc (rpmlib, GLIBC filtered): pioneer-debuginfo (rpmlib, GLIBC filtered): Provides -------- pioneer: appdata() appdata(pioneer.appdata.xml) application() application(pioneer.desktop) pioneer pioneer(x86-64) pioneer-data: pioneer-data pioneer-doc: pioneer-doc pioneer-debuginfo: pioneer-debuginfo pioneer-debuginfo(x86-64) Source checksums ---------------- https://github.com/pioneerspacesim/pioneer/archive/20160512.tar.gz#/pioneer-20160512.tar.gz : CHECKSUM(SHA256) this package : 4520de344d2dc02301d198c47feaa24d79fa15e835ba4abed357d51adc86beba CHECKSUM(SHA256) upstream package : 4520de344d2dc02301d198c47feaa24d79fa15e835ba4abed357d51adc86beba Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1339158 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Note: fedora-review did not, for whatever reason, automatically rpmlint the fonts packages or check their provides/requires, so I have done that myself. $ rpmlint ./pioneer-*-fonts* pioneer-inpionata-fonts.noarch: W: no-documentation pioneer-orbiteer-bold-fonts.noarch: W: no-documentation pioneer-pionilliumtext22l-medium-fonts.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpm -qpR ./pioneer-*-fonts* fontpackages-filesystem rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 fontpackages-filesystem rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 fontpackages-filesystem rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx