[Bug 1336726] Review Request: erlang-lucene_parser - A library for Lucene-like query syntax parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1336726

Peter Lemenkov <lemenkov@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(lemenkov@xxxxxxxx |
                   |m)                          |



--- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
Hello, Randy!
Thanks for reviewing this, and here is a story behind this package.

About 6 years ago lucene_parser was bundled with riak_search application and
now is shipped with riak_search. This is very unusual - typically Erlang
application consists of a bunch of libraries, which in turn depends on other
libraries. Typically this all is being fetched by rebar - one package by
another accordingly to a rebar.config contents.

Shipping two libraries with different versions in the same tarball causes
issues while installing and building dependency graph, and I really don't think
we should add a special exception just for this case.

I've asked upstream if it's possible to split this library off:

https://github.com/basho/riak_search/issues/180

Regarding version - lucene_parser does has it's own version number. It's "1"
(not "1.0", or "1.0.0", or anything else). See this file:

*
https://github.com/basho/riak_search/blob/7818ac9/apps/lucene_parser/src/lucene_parser.app.src#L4

Regarding source tarball. I agree with you - it's better to ship not the latest
tarball of riak_search as a source, but rather a corresponding snapshot of this
commit:

* https://github.com/basho/riak_search/tree/7818ac9

If you have any questions or I did made anything even more unclear then don't
hesitate to ask :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]