https://bugzilla.redhat.com/show_bug.cgi?id=1338339 --- Comment #5 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- --- main pkg > Source0: https://github.com/rdiankov/openrave/archive/%{commit}/openrave-%{commit}.tar.gz I would prefer to use: https://github.com/rdiankov/openrave/archive/%{commit}/openrave-%{shortcommit}.tar.gz Up to you. > Provides: bundled(ivcon) = 0 don't need version here --- -devel subpkg > Requires: %{name} = %{version}-%{release} Forgot to add %{?_isa} after %{name} --- %build section > -DCMAKE_BUILD_TYPE=RelWithDebInfo \ not needed, %cmake does this for you > -DBASH_COMPLETION_DIR="%{_sysconfdir}/bash_completion.d" \ I think it could be detected automatically (in CMakeLists, didn't check upstream sources). Anyway proper path is %{_datadir}/bash-completion/completions/ > make %{?_smp_mflags} can be replaced with %make_build, up to you --- %install section > make install DESTDIR=%{buildroot} can be replaced with %make_install, up to you > find %{buildroot} -name '*.la' -exec rm -f {} ';' replace with: find %{buildroot}%{_libdir} -type f -name '*.la' -delete ';' > bash_completion stuff see above --- %files sections -> once you will move bash_completion stuff into %{_datadir} remove %config(noreplace) > %{_datadir}/%{name}/openrave.bash I think it shouldn't go here > %{_bindir}/openrave-createplugin.py I would prefer to have this file without .py suffix Also would be better to change shebang to something like /usr/bin/python2 and add Requires: python2-%{name} because this script requires Python module --- Other notes -> Is it possible to build python3 subpackage? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx