https://bugzilla.redhat.com/show_bug.cgi?id=1317887 --- Comment #9 from Michael Schwendt <bugs.michael@xxxxxxx> --- > Name: libfastjson > Group: Development/Libraries And after many years, in 2016 the base group for runtime library packages still is "System Environment/Libraries". I wonder which packages you've looked at as examples? Btw, nowadays the Group tag is optional: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > Requires: pkgconfig Unjustified and overly restrictive. There is absolutely no need for an explicit dependency on pkgconfig. Certainly you could use libfastjson-devel without using pkg-config. Further, for several years already, there are automatic Requires/Provides for packages containing and depending on .pc files. > %check > make V=1 check > > %install That's the wrong order of those sections. Not a major issue, but the %check section is processed _after_ %install (so it would be possible to run checks inside the buildroot). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx