https://bugzilla.redhat.com/show_bug.cgi?id=1332720 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- builds/installs locally ok (with minor %%files adjustments, appears to be several small typos) naming: ok sources: ok 6a3ce0c4d1c08f0de1245c83795e207d kdepim-addons-16.04.0.tar.xz URL: Not valid 1. Should fix URL to (something like): URL: https://quickgit.kde.org/?p=%{framework}.git macros: ok scriptlets: ok 2. SHOULD fix Conflicts/Obsoletes to not use %{_isa} (but reference real packages): Obsoletes: kdepim-libs%{?_isa} < 16.04.0 Conflicts: kdepim-libs%{?_isa} < 16.04.0 Otherwise, looks good, follows conventions of other kf5/pim related packages, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx