https://bugzilla.redhat.com/show_bug.cgi?id=1332719 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- after gathering deps by hand, builds/isntalls locally ok naming: ok sources: ok 677cb160d12d5731a296b3f6a24bc270 kdepim-apps-libs-16.04.0.tar.xz license: ok URL: Not valid 1. Should fix URL to (something like): URL: https://quickgit.kde.org/?p=%{framework}.git macros: ok scriptlets: ok 2. SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}), Obsoletes: kdepim-libs%{?_isa} < 16.04.0 Conflicts: kdepim-libs%{?_isa} < 16.04.0 Otherwise, pretty simple and clean, follows conventions of other kf5/pim related packages. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx