[Bug 1336833] Review Request: resultsdb_api - API to resultsdb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1336833



--- Comment #3 from James Hogarth <james.hogarth@xxxxxxxxx> ---
I'm pretty busy during the day but a couple of quick observations for you to
fix for the review:

You shouldn't have this at the start:
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

There is no fedora before 12 to build for, and I'd be surprised if EPEL5 was a
target.

Obsoletes: resultsdb_api < %{version}-%{release}

Since resultsdb_api isn't in fedora it shouldn't be in the review spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]