https://bugzilla.redhat.com/show_bug.cgi?id=1338140 --- Comment #9 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Raphael Groner from comment #7) > Package Review > ============== > ===== MUST items ===== > Generic: > [?]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "BSD (3 clause)", "LGPL (v2.1 or later)", "GPL (v3 or later)", > "Unknown or generated", "*No copyright* Public domain". 169 files have > unknown license. Detailed output of licensecheck in /home/builder > /fedora-review/1338140-guayadeque/licensecheck.txt > => Please explain why those files with no license header. don't know, will ask upstream. > [x]: License file installed when any subpackage combination is installed. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > [x]: %build honors applicable compiler flags or justifies otherwise. > [?]: Package contains no bundled libraries without FPC exception. > => Source files without license header, see above. don't know, will ask upstream. > > [x]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 10240 bytes in 1 files. > [?]: Package complies to the Packaging Guidelines > => see above, licensing/bundling? > > ===== SHOULD items ===== > > [?]: Package functions as described. > [?]: Latest version is packaged. > => Latest commit is 13013ff, 2016-05-22. Maybe take this tarball. next package will contains the recent version > ===== EXTRA items ===== > > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 1781760 bytes in /usr/share > => Please split locales into a l10n subpackage. don't know how to split in a l10n package, need assistance here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx