[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1323186



--- Comment #18 from Rick Tierney <rick.tierney@xxxxxxxxx> ---
Thanks, that works!

Ok, so I have a few issues I'll need help with...

Rpmlint (4 warnings)
---------------------
1. The URL tag is supposed to point to a public web site where we have
documentation, but at the moment this is unavailable. My attempts to point to
the GitHub URL (https://github.com/01org/opa-fmgui/tree/Fedora_Review) have
failed. Previous attempts at just using http://www.intel.com/ have also failed
due to an inability to resolve these URLs.  Any suggestions or can this be
ommitted?

2. The current entry for the Source0 tag is opa-fmgui-10.0.0.0.3.tar.gz, but
this is supposed to be a publicly accessible URL. My predecessor (Robert Amato)
has an archive at URL: https://github.com/01org/opa-fmgui/archive/v1.1.tar.gz. 
When I attempted to enter this URL for the Source0 tag it couldn't be found. 
Are there restrictions on the naming of this archive; i.e. does it need to
match the project-version-release format? 

3. Another warning that came up was:  opa-fmgui.noarch: W:
no-manual-page-for-binary fmgui
I don't have a man-page at the moment, can it be omitted?

4. The opa-fmgui is a Java application (not a library).  At run-time, the
Class-Path field in MANIFEST.MF lists all of the jar-files needed to run the
application.  This is the traditional way of providing path information.  This
apparently goes against the guidelines set forth by Fedora and is explained by
rpmlint as a problem because "these entries don't work with older Java versions
and even if they do work, they are inflexible and usually cause nasty
surprises".  According to the Java packaging guidelines at

          
https://fedoraproject.org/wiki/Packaging:Java#No_class-path_in_MANIFEST.MF

the Class-Path can't be used, and so the "packager SHOULD use one of tools
designed to locating JAR files in the system."  I'm not really sure how to
handle this; i.e. Class-Path was always to goto for solving dependency issues
at run-time.  Do you have a standard way of dealing with this that complies
with Fedora guidelines?

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]