[Bug 1300219] Review Request: python-ripe-atlas-cousteau - Python wrapper for RIPE Atlas API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1300219



--- Comment #7 from Jan Včelák <jv+fedora@xxxxxxxxx> ---
(In reply to Paul Wouters from comment #4)
> python3-ripe-atlas-cousteau.noarch: W: python-bytecode-without-source
> /usr/lib/python3.5/site-packages/ripe/atlas/cousteau/__pycache__/source.
> cpython-35.opt-1.pyc

I'll recheck what's going on.

(In reply to Paul Wouters from comment #5)
> One minor nit: Please do not use macros in the URL: entry. These entries
> should be updated for each package anywya, and it prevents someone from
> looking in the spec file and right-clicking to go to the site.

OK. I'll remove the URL.

(In reply to Paul Wouters from comment #6)
> NOTE: the site-packages/ripe package directory is also owned by other ripe
> packages.

I think this is correct in this case. And also allowed by the guidelines:

https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

Thank you, Paul!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]