https://bugzilla.redhat.com/show_bug.cgi?id=1338537 --- Comment #12 from Ralf Senderek <fedora@xxxxxxxxxxx> --- Just a few small changes before I start the formal review: 1) I understand that you intend to maintain a single source tarball that can be used to package in different distributions. At the moment this leads to 14 files with no known licenses. It is quite easy to resolve this as you can remove files from the builddirectory in the %prep macro before the software is compiled. Just change: %prep %setup -q rm -rf %{_builddir}/%{name}-%{version}/debian rm -rf %{_builddir}/%{name}-%{version}/any-other-unused-file 2) Please remove NEWS, because it is an empty file. 3) If you have officially build release 1, change the release to 2 and include the new spec file in a new SRPM. This is important, because at the moment your SRPM contains the old initial spec file. I recommend to keep both the new spec file and the SRPM up-to-date whenever you make any changes. And please update the changelog in the spec-file. Once this is done, I'll start the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx