https://bugzilla.redhat.com/show_bug.cgi?id=1338537 Ralf Senderek <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxx --- Comment #7 from Ralf Senderek <fedora@xxxxxxxxxxx> --- Your new spec file looks much better now. It's always a good idea to run rpmlint against your newly built rpm files. Its output is not always correct, but it gives a hint where issues may turn up in the formal review. One point that is checked thoroughly in the review is the license of your files. You are using a standard license which has a short name of "ASL 2.0" according to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses So if you delete the "v" you should be good here. Your source file seems to be taken from a debian background, it contains many files that make sense only if you build a deb package. If possible, I recommend that you include only the few necessary files in the source code archive, because otherwise you'll end up with a number of files for which the review tool cannot assign a proper license. If you wish to see the results of an automatic package review for your package, install fedora-review and run "fedora-review -n tarmux" as a normal user in a directory where your spec file and SRPM exist. (You may have to add that user to the mock group.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx