https://bugzilla.redhat.com/show_bug.cgi?id=1338537 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Even before initiating a Fedora review, there are several problems with this spec. Aside from the fact that you published a spec.in file (which is not acceptable, you *must* publish the spec that is actually used in the source RPM), the packaging style is completely wrong. Here are the issues: * Defined BuildRoot and Packager. While BuildRoot doesn't hurt anything and is usually ignored, Packager is *never* supposed to be defined. That *must* be stripped out. %buildroot is automatically defined by RPM during build time. * Using overloaded macro variables to define fields. While this is not exactly not permitted, overloading the macro variables to define the fields is not. Please just put them into the fields themselves. It's redundant and pointless since the fields define those macro variables anyway. * Not using a path to sources. It makes life easier if the Source field is defined with a direct path to it. For example: "https://github.com/minfrin/%{name}/releases/download/%{name}-%{version}/%{name}-%{version}.tar.bz2"; instead of just %{name}-%{version}.tar.bz2. * No usage of %{dist} in Release. Your release should be X%{?dist} instead of just X. For example, your Release field should be set to "1%{?dist}". See https://fedoraproject.org/wiki/Packaging:DistTag * Using Prefix. This is not permitted in Fedora at all. Please do not attempt to make a relocatable package. It causes too many weird things to happen. * Inadequate specification of build-time dependencies. Please specify all the components required to build (including compiler, etc.). We do not guarantee that a compiler will be present in the buildroot (even though currently one is always present). * Not using parallel make. Please use %make_build to specify parallel make build after running %configure. By default, Fedora prefers builds to be run with make -jX, and %make_build properly handles that for you. Run "rpm -E '%make_build'" to verify for yourself. * Redundant specification of parameters. The %configure macro already specifies all the things you're laying out there. Run "rpm -E '%configure'" to verify for yourself. * Empty scriptlet sections (%pre, %post, %preun). Please delete these as they add unnecessary bloat to the generated RPMs. * Redundant %clean section: Unless you're packaging for RHEL/CentOS 5, you don't need it, as RPM already has it pre-defined. * Redundant buildroot cleaning in %install phase and non-usage of %make_install macro. Again, unless you're targeting RHEL/CentOS 5, you don't need to clean the buildroot at the beginning of the %install section. As for the install, please use '%make_install'. It does the same thing, except it's cleaner. Run "rpm -E '%make_install'" to verify for yourself. * Usage of %attr in the file list. Do you really need this? Wouldn't the installation from your build scripts already set this? If not, perhaps you should fix it there. Usage of %attr is usually unnecessary if the build system can set it when make install is run. Please address all of these. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx