https://bugzilla.redhat.com/show_bug.cgi?id=1331972 --- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> --- SPEC: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/Ipopt-EPEL/qblade.git/plain/qblade.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/sagitter/Ipopt-EPEL/fedora-rawhide-x86_64/00304407-qblade/qblade-0.91-1.fc25.src.rpm - Unbundle Eigen - Version changed to 0.91 (In reply to Jerry James from comment #2) > Issues: > 1. This package has a bundled copy of eigen3. Is that necessary, or can the > system eigen3 be used? Note that the bundled code has licenses that > differ > from the main package, namely some of it is MPL, some LGPL, and some BSD. > If eigen3 is not unbundled, the License field will have to be updated to > reflect this. Eigen removed; I had missed it. > > 2. The appdata.xml file contains a copyright notice for Richard Hughes. > Really, or is that a cut and paste oversight? (I'm also not certain that > declaring a copyright is useful, since the CC0 declaration is essentially > an abandonment of copyright.) It's a legacy from an old file. > > 3. Regarding version numbering, it looks like upstream intends this to be > version 0.91, not 0.9.1. At least, I see the string "0.91" in several > places, such as src/MainFrame.cpp, src/QBladeApplication.cpp, and > src/XBEM/BEM.cpp. That change would let you insert a %{version} into the > %setup line in %prep. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx