https://bugzilla.redhat.com/show_bug.cgi?id=1160671 --- Comment #10 from Julien Enselme <jujens@xxxxxxxxx> --- > these are already installed both on buildroot and on runtime since they are pulled as dependencies of other dependencies (ccnet and libsearpc). I think you should put them anyway: one of the dependency may change its dependencies and one of these packages may then not be pulled. Furthermore, I think it is better to make dependencies explicit in a package. > Installing mysql-devel will bring mysql on runtime, which seems a bit overkill for the purposes of running the desktop client. Indeed, I think you can skip that one without any problem. > This causes the build to fail, since some upstream tests fail. I'll open a bug ipstream, but maybe we shouldn't block the review for this. The %check section is a should item, it won't block the review. Opening a bug upstream sounds like a good idea. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx