https://bugzilla.redhat.com/show_bug.cgi?id=1337120 --- Comment #12 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Dmitrij S. Kryzhevich from comment #11) > There are two more issues. > > 1. There is a %{_bindir} macro for /usr/bin. There are several entries in > spec for it to be modified. Thanx! Crap. How could I overlook it:( > 2. %attr macro is not applicable to symlinks. First /usr/bin/gyazo in %files > section should go without it. I believe the attr macro on symlink is reaction to the rpm lint warning. Anyway - it od not harm. > > Not issue but, what is the reason for debug_package variable in spec? Without it, the rpm build fail trying to generate debuginfo. > > And one little suggestion. > Could you patch sript to move out all ~/.* stuff into may be > ~/.config/gyazo/* ? hm. On one side yes, on second... It *big* patch. As .config is not always the location. XDG_CONFIG_DIR have to point to this, or if XDG_CONFIG_DIR variable is empty, then ~/.config is used. Considering that this config file is nearly undocumented, and it seems that if usable - then only to avoid imagemagic... I think the patch is not worthy. Anyway - I would like to skip it from review - but may be good practice for fresh packager :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx