https://bugzilla.redhat.com/show_bug.cgi?id=1321416 --- Comment #5 from philip.worrall@xxxxxxxxxxxxxx --- Thanks for posting a revision. Could you indicate which items you have addressed and which you haven't. A quick scan shows you're still using the git sources but upstream provide a release tarball that includes documentation. You could clean up all those global variables by using this and in the files section put %license LICENSE, %doc README.md etc. Is there any particular reason why you want to use git directly? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx