https://bugzilla.redhat.com/show_bug.cgi?id=1331175 Tim Byrne <sultan@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sultan@locehilios | |.com) | --- Comment #3 from Tim Byrne <sultan@xxxxxxxxxxxxxx> --- Thanks for the feedback. I've made an effort to resolve all discrepancies noted. Updated Spec URL: https://raw.githubusercontent.com/TheLocehiliosan/yadm-rpm/master/yadm.spec Updated SRPM URL: https://raw.githubusercontent.com/TheLocehiliosan/yadm-rpm/master/yadm-1.04-2.fc23.src.rpm * License and docs are properly included * `%defattr` has been removed * `%check` has been implemented * `%{?dist}` macro has been added to the `Release` * All new build dependencies have been added * Updated changelog to indicate this as the initial fedora package * Made RPM description and man page description match. * Removed `Group` tag * `gnupg` is *not* currently listed as a dependency. yadm gracefully limits it's functionality if `gnupg` is not installed. It isn't required. Updated Koji build example: http://koji.fedoraproject.org/koji/taskinfo?taskID=14132096 Updated rpmlint: 1 packages and 1 specfiles checked; 0 errors, 0 warnings. Cheers -Tim -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx