Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: R-widgetTools-1.12.0-2 - Tools to support the construction of tcltk widgets https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241081 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-06-28 00:05 EST ------- > I'm confused by the dependencies. This pachage seems to have no requirements > besides /bin/sh needed to run the scriptlets. Shouldn't it depend on R as well > as tcl and tk? It should. R-widgetTools makes R able to build tcltk widgets (tell me if i'm wrong). Also, the scriptlets action need index.txt which owned by R. However, tcl and tk packages no need to be added as Requires, they are already require by R package. = additional comment = Installing R-WidgetTools under x86_64 arch make the scriptlets fails to work. Cause %{_libdir} is defined as /usr/lib instead of /usr/lib64 due to noarch package set for R-widgetTools. > The final package is mostly documentation. The whole package isn't huge so I > don't think it's mandatory that it be split into a -doc subpackage and I know > that R has its own internal documentation browser system, but I still have to > wonder if the documentation in this package shouldn't be marked as %doc so a > smaller --excludedocs installation is possible. The question is simple: does > the package still work if you delete all of the documentation files. If so, > those files should all be marked as %doc. Remove docs files don't affect the use of R and R-widgetTools. It's just that if you invoke an htlm doc from R prompt, it will fails to find it/them (from htlm browser or online-help). So, i think that we can think about slip them into a -doc subpackage. * move them to %doc will make them out to work. But, if you really want them here, you will have to change all path which are in CONTENT file to point them to %{_docdir}/%{name}-%{version}/html instead of ../../../library/widgetTools/html As you can see, it go back 3 level down and then move to widgetTools/htlm. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review