Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-salut - Link-local XMPP telepathy connection manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240323 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-27 23:26 EST ------- Not much to say here. rpmlint just complains about W: telepathy-salut mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) which is no big deal. Review: * source files match upstream: 14d2db936bcfdb8e441536106bfcce7f2f59e6d0d4f635af22657801345139ab telepathy-salut-0.1.3.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint nas only acceptable complaints. * final provides and requires are sane: telepathy-salut = 0.1.3-1.fc8 = libavahi-client.so.3()(64bit) libavahi-common.so.3()(64bit) libavahi-glib.so.1()(64bit) libcrypto.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libssl.so.6()(64bit) libtelepathy-glib.so.0()(64bit) libxml2.so.2()(64bit) libz.so.1()(64bit) telepathy-filesystem * %check is not present; no test suite upstream. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. /usr/share/dbus1-service is owned by dbus, a dependency via libdbus /usr/share/telepathy-managers is owned by telepathy-filesystem * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review