https://bugzilla.redhat.com/show_bug.cgi?id=1324204 --- Comment #8 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to Ondrej Faměra from comment #7) > > * Your SPEC file name doesn't match the package name. > > https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_File_Naming > - renamed to fast-vm.spec Ack. > > * %description line 29 is too long. > > Line length shouldn't exceed 80 characters; cut it into two. > - done, put into new line Ack. > > * %{_libexecdir}/%{name}-helper.sh permissions look strange. > > The file isn't world readable/executable. Wouldn't 755 make more sense? > - the file is not intended to be executable by anyone other than root, but > can be readable by people - changed to 744. Alright. > > * It appears 440 permissions are more common for sudoers files. > > This isn't very important but consider changing yours. > - changed to 440 Ack. > > * Mark your sudoers file as configuration. > > https://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files > - marked Ack. > > * You should own the %{_datadir}/bash-completion/completions directory. > > Just change line 45 to %{_datadir}/bash-completion/completions. > - changed Ack. > Thank you for suggestions. New .spec file and SRPM with changes from above > can be found below. > > SRPM URL: > https://github.com/OndrejHome/fast-vm/releases/download/0.6.1/fast-vm-0.6.1- > 1.fc22.src.rpm > Spec URL: > https://raw.githubusercontent.com/OndrejHome/fast-vm/develop/rpm/fast-vm.spec -- Now for the dependencies -- we've gone through them together in person so I'll just list the required changes in here without explaining that in detail: - Don't require bash - Require coreutils - Require ncurses - Require openssh-clients - Require sed - dnsmasq-utils should be required, not recommended - Recommend awk - Remove the libguestfs-tools-ca "suggests" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx