https://bugzilla.redhat.com/show_bug.cgi?id=1326277 --- Comment #5 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MIT/X11 (BSD like)", "Unknown or generated". 83 files have unknown license. Detailed output of licensecheck in /home/lsm5/1326277-ocitools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gocode/src/github.com/opencontainers/ocitools/cmd --- gotta own this one [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src/github.com/opencontainers/ocitools/cmd, /usr/share/gocode/src, /usr/share/gocode, /usr/share/gocode/src/github.com --- /usr/share/gocode{/src{/github.com}} should be owned by golang-devel package I think. I'm thinking we can waive this and file a bug against the main golang package itself. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/opencontainers(golang-github- opencontainers-specs-devel, golang-github-opencontainers-runtime-spec- devel, runc-devel) --- some upper level dirs are common to devel subpackages in other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx