[Bug 1203380] Review Request: gherkin-java - A fast lexer and parser for the Gherkin language based on Ragel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1203380

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(puntogil@libero.i |
                   |t)                          |



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Raphael Groner from comment #2)

> [x]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "MIT/X11 (BSD like)", "Unknown or generated". 200 files have
>      unknown license. Detailed output of licensecheck in /home/builder
>      /fedora-review/1203380-gherkin-java/licensecheck.txt
> => MIT/X11, no license text.
The files
gherkin-2.12.2/java/pom.xml
gherkin-2.12.2/gherkin.gemspec
report license as MIT and license file is available
gherkin-2.12.2/LICENSE
what is the problem?

> Generic:
> [!]: Sources can be downloaded from URI in Source: tag
>      Note: Could not download Source0:
>      https://github.com/cucumber/gherkin/archive/v2.12.2.tar.gz
>      See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
> => Version 4.0.0 is current at upstream, use it instead?

> [x]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gherkin-
>      java-javadoc
> => javadoc is independent.

No, i am not interested to package the other stuff... and rubygem-gherkin is
already available in our repos.
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-gherkin

> [?]: Package functions as described.
> [!]: Latest version is packaged.
> => Use version 4.0.0?
> 

Not sure about backward compatibility, and no, i am not interested @ the moment

> 
> Rpmlint
> -------
> Checking: gherkin-java-2.12.2-1.fc25.noarch.rpm
>           gherkin-java-javadoc-2.12.2-1.fc25.noarch.rpm
>           gherkin-java-2.12.2-1.fc25.src.rpm
> gherkin-java.noarch: W: no-manual-page-for-binary gherkin
> gherkin-java.src: W: invalid-url Source0:
> https://github.com/cucumber/gherkin/archive/v2.12.2.tar.gz HTTP Error 404:
> Not Found
> 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Damm ...
moved @ https://github.com/cucumber/gherkin2/archive/v2.12.2.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]