Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: avarice - Program for interfacing the Atmel JTAG ICE to GDB https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231814 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-06-27 20:41 EST ------- I have absolutely no idea what an Atmel JTAG ICE is, so there's no chance that I could test in any way, but I figure I can at least look over the packaging. You might consider using http://avarice.sourceforge.net/ for the URL as it's a bit more descriptive than the sourceforge project page, but it's also a bit out of date (saying that 2.3 is the current version). Your %description is missing a period. Those are terribly minor, though; I see nothing which would block this package. Review: * source files match upstream: c916cc130755c38cebf2d09b84fce6530e78c8bf28acab87afedbc77ac464a5a avarice-2.6.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK (outside of the missing period) * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: avarice = 2.6-1.fc8 = /bin/sh /usr/bin/perl libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) * %check is not present; no test suite upstream and I haven't the hardware to test this manually. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review