[Bug 1335076] Review Request: perl-String-Dirify - String::Dirify Perl module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1335076



--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Standalone and packages spec files differ. I will use the standalone one as it
seems more correct because it does not build-require Test::Pod module.

URL and Source0 addresses are usable. Ok.
Source archive (SHA-256:
8e66374ade8b447ba94d276616973ef8a249e5b6258b81662142daa712329d53) is original.
Ok.

FIX: The summary is a dummy text. Please use a tesx from lib/String/Dirify.pm
POD (Convert a string into a directory name).

Summary verified from lib/String/Dirify.pm. Ok.
License verified from Makefile.PL and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl' (perl-String-Dirify.spec:16).
FIX: Build-require `perl-generators'.
FIX: Build-require `make' (perl-String-Dirify.spec:30).

All tests pass. Ok.

$ rpmlint perl-String-Dirify.spec
../SRPMS/perl-String-Dirify-1.03-1.fc25.src.rpm
../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 
drwxr-xr-x    2 root    root                        0 May 13 14:20
/usr/share/doc/perl-String-Dirify
-rw-r--r--    1 root    root                      996 May 11 01:36
/usr/share/doc/perl-String-Dirify/Changes
-rw-r--r--    1 root    root                     2406 Nov 16  2010
/usr/share/doc/perl-String-Dirify/README
drwxr-xr-x    2 root    root                        0 May 13 14:20
/usr/share/licenses/perl-String-Dirify
-rw-r--r--    1 root    root                    20231 May 11 01:28
/usr/share/licenses/perl-String-Dirify/LICENSE
-rw-r--r--    1 root    root                     2308 May 13 14:20
/usr/share/man/man3/String::Dirify.3pm.gz
drwxr-xr-x    2 root    root                        0 May 13 14:20
/usr/share/perl5/vendor_perl/String
-rw-r--r--    1 root    root                     6901 May 11 01:39
/usr/share/perl5/vendor_perl/String/Dirify.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm
| sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.22.2)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm
| sort -f | uniq -c
      1 perl(String::Dirify) = 1.03
      1 perl-String-Dirify = 1.03-1.fc25
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F25
(http://koji.fedoraproject.org/koji/taskinfo?taskID=14042709). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items and provide a new spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]