https://bugzilla.redhat.com/show_bug.cgi?id=1335288 Jon Ciesla <limburgher@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jon Ciesla <limburgher@xxxxxxxxx> --- Good: - rpmlint checks return: python3-pyudev.src: W: spelling-error Summary(en_US) libudev -> Libreville The value of this tag appears to be misspelled. Please double-check. python3-pyudev.src: W: spelling-error %description -l en_US libudev -> Libreville The value of this tag appears to be misspelled. Please double-check. python3-pyudev.src: W: spelling-error %description -l en_US wxPython -> python, Python The value of this tag appears to be misspelled. Please double-check. python3-pyudev.src: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Ignorable. . . python3-pyudev.noarch: W: incoherent-version-in-changelog 0.20.0 ['0.20.0-1.fc23', '0.20.0-1'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. Add the release to the changelog, a la 0.20.0-1 - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Looks great, just fix the changelog NVR and you're good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx