https://bugzilla.redhat.com/show_bug.cgi?id=1329188 --- Comment #10 from Krzysztof Czurylo <krzysztof.czurylo@xxxxxxxxx> --- Spec URL: https://github.com/pmem/nvml/releases/download/1.0/nvml.spec SRPM URL: https://github.com/pmem/nvml/releases/download/1.0/nvml-1.0-1.fc23.src.rpm Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13985526 Below is the output from fedora-review tool with items requiring manual review filled out. Added notes on: license, bundled libraries, excluded architectures, large documentation, latest version, patches and rpmlint spelling-error warnings. (grep for **Note** tag). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "MIT/X11 (BSD like)", "Unknown or generated", "CDDL". 229 files have unknown license. Detailed output of licensecheck in /home/krzycz/rpmbuild/SRPMS/nvml/licensecheck.txt **Note**: NVML is released under BSD (3 clause) license. BSD (2 clause) applies to jemalloc library, which is statically linked to libvmem and libvmmalloc libraries. CDDL and MIT/X11 licenses apply to some utility scripts or unit test code, which are not a part of the binary packages. LICENSE file installed with each subpackage includes the above information. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. **Note**: libvmem and libvmmmaloc contain statically linked jemalloc library. This is a significantly modified version of jemalloc 3.6, including NVML-specific changes, not available upstream. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. **Note**: At the moment, the only supported arch is x86_64. This is because of dependency on on xmmintrin.h and some inline assembly. Other 64-bit architectures could also be supported, if only there is a request for that, and if somebody provides the arch-specific implementation of the low-level routines for flushing to persistent memory. 32-bit architectures are not supported by design. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 266240 bytes in 39 files. **Note**: Same 3 files installed with each subpackage. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libpmem , libpmem-devel , libpmemblk , libpmemblk-devel , libpmemlog , libpmemlog-devel , libpmemobj , libpmemobj-devel , libvmem , libvmem- devel , libvmmalloc , libvmmalloc-devel , nvml-tools , nvml-debuginfo [x]: Package functions as described. [!]: Latest version is packaged. **Note**: The packaged version is the latest stable NVML release - version 1.0. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. **Note**: The patches were required to honor applicable compiler flags and to fix one of the unit tests that was sporadically timeouting in "%check". They do not affect the library code. Both patches has been already merged upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: libpmem-1.0-1.fc23.x86_64.rpm libpmem-devel-1.0-1.fc23.x86_64.rpm libpmemblk-1.0-1.fc23.x86_64.rpm libpmemblk-devel-1.0-1.fc23.x86_64.rpm libpmemlog-1.0-1.fc23.x86_64.rpm libpmemlog-devel-1.0-1.fc23.x86_64.rpm libpmemobj-1.0-1.fc23.x86_64.rpm libpmemobj-devel-1.0-1.fc23.x86_64.rpm libvmem-1.0-1.fc23.x86_64.rpm libvmem-devel-1.0-1.fc23.x86_64.rpm libvmmalloc-1.0-1.fc23.x86_64.rpm libvmmalloc-devel-1.0-1.fc23.x86_64.rpm nvml-tools-1.0-1.fc23.x86_64.rpm nvml-debuginfo-1.0-1.fc23.x86_64.rpm nvml-1.0-1.fc23.src.rpm libpmem.x86_64: W: spelling-error %description -l en_US pmem -> poem, pm em, pm-em libpmem-devel.x86_64: W: spelling-error %description -l en_US pmem -> poem, pm em, pm-em libpmem-devel.x86_64: W: spelling-error %description -l en_US libpmemobj -> memorabilia libpmemblk.x86_64: W: spelling-error %description -l en_US pmem -> poem, pm em, pm-em libpmemblk-devel.x86_64: W: spelling-error %description -l en_US pmem -> poem, pm em, pm-em libpmemblk-devel.x86_64: W: spelling-error %description -l en_US libpmemobj -> memorabilia libpmemlog.x86_64: W: spelling-error %description -l en_US pmem -> poem, pm em, pm-em libpmemlog-devel.x86_64: W: spelling-error %description -l en_US pmem -> poem, pm em, pm-em libpmemlog-devel.x86_64: W: spelling-error %description -l en_US libpmemobj -> memorabilia libpmemobj.x86_64: W: spelling-error %description -l en_US transactional -> transaction, transnational, transitional libpmemobj-devel.x86_64: W: spelling-error %description -l en_US transactional -> transaction, transnational, transitional libvmem.x86_64: W: spelling-error %description -l en_US malloc -> mallow libvmem-devel.x86_64: W: spelling-error %description -l en_US malloc -> mallow 15 packages and 0 specfiles checked; 0 errors, 13 warnings. **Note**: False positives. Rpmlint (debuginfo) ------------------- Checking: nvml-debuginfo-1.0-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 14 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- libvmem-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpthread.so.0()(64bit) libvmem libvmem.so.1()(64bit) rtld(GNU_HASH) nvml-tools (rpmlib, GLIBC filtered): config(nvml-tools) libc.so.6()(64bit) libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpmemblk.so.1()(64bit) libpmemblk.so.1(LIBPMEMBLK_1.0)(64bit) libpmemlog.so.1()(64bit) libpmemlog.so.1(LIBPMEMLOG_1.0)(64bit) libpmemobj.so.1()(64bit) libpmemobj.so.1(LIBPMEMOBJ_1.0)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libpmemblk-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpmem-devel libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpmemblk libpmemblk.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libpmem-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpmem libpmem.so.1()(64bit) rtld(GNU_HASH) libvmmalloc (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libpmemlog (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libvmem (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libpmemobj-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpmem-devel libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpmemobj libpmemobj.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libpmemblk (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libvmmalloc-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpthread.so.0()(64bit) libvmmalloc libvmmalloc.so.1()(64bit) rtld(GNU_HASH) libpmem (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) rtld(GNU_HASH) nvml-debuginfo (rpmlib, GLIBC filtered): libpmemlog-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpmem-devel libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpmemlog libpmemlog.so.1()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libpmemobj (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- libvmem-devel: libvmem-devel libvmem-devel(x86-64) libvmem.so.1()(64bit) libvmem.so.1(LIBVMEM_1.0)(64bit) pkgconfig(libvmem) nvml-tools: config(nvml-tools) nvml-tools nvml-tools(x86-64) libpmemblk-devel: libpmemblk-devel libpmemblk-devel(x86-64) libpmemblk.so.1()(64bit) libpmemblk.so.1(LIBPMEMBLK_1.0)(64bit) pkgconfig(libpmemblk) libpmem-devel: libpmem-devel libpmem-devel(x86-64) libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) pkgconfig(libpmem) libvmmalloc: libvmmalloc libvmmalloc(x86-64) libvmmalloc.so.1()(64bit) libpmemlog: libpmemlog libpmemlog(x86-64) libpmemlog.so.1()(64bit) libpmemlog.so.1(LIBPMEMLOG_1.0)(64bit) libvmem: libvmem libvmem(x86-64) libvmem.so.1()(64bit) libvmem.so.1(LIBVMEM_1.0)(64bit) libpmemobj-devel: libpmemobj-devel libpmemobj-devel(x86-64) libpmemobj.so.1()(64bit) libpmemobj.so.1(LIBPMEMOBJ_1.0)(64bit) pkgconfig(libpmemobj) libpmemblk: libpmemblk libpmemblk(x86-64) libpmemblk.so.1()(64bit) libpmemblk.so.1(LIBPMEMBLK_1.0)(64bit) libvmmalloc-devel: libvmmalloc-devel libvmmalloc-devel(x86-64) libvmmalloc.so.1()(64bit) pkgconfig(libvmmalloc) libpmem: libpmem libpmem(x86-64) libpmem.so.1()(64bit) libpmem.so.1(LIBPMEM_1.0)(64bit) nvml-debuginfo: nvml-debuginfo nvml-debuginfo(x86-64) libpmemlog-devel: libpmemlog-devel libpmemlog-devel(x86-64) libpmemlog.so.1()(64bit) libpmemlog.so.1(LIBPMEMLOG_1.0)(64bit) pkgconfig(libpmemlog) libpmemobj: libpmemobj libpmemobj(x86-64) libpmemobj.so.1()(64bit) libpmemobj.so.1(LIBPMEMOBJ_1.0)(64bit) Source checksums ---------------- https://github.com/pmem/nvml/archive/1.0.tar.gz : CHECKSUM(SHA256) this package : 2caf7b7242665e05ff824ae81dfdbc40f17e3bde9bcfad69889b9bbb7f9c7f73 CHECKSUM(SHA256) upstream package : 2caf7b7242665e05ff824ae81dfdbc40f17e3bde9bcfad69889b9bbb7f9c7f73 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review --rpm-spec -n nvml Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx