https://bugzilla.redhat.com/show_bug.cgi?id=1331363 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- I will use a spec file from the source RPM file. Url and Source addresses are usable. Ok. Source archive (SHA-256: b1bd90478d9cc75f4c7dfa4dbee6fd0c0a40a1a529288df72697873308294831) is original. Ok. Summary verified from lib/Crypt/RandPasswd.pm. Ok. Description verified from lib/Crypt/RandPasswd.pm. Ok. TODO: I think copying the second DESCRIPTION paragraph from the POD would be beneficial. License verified from lib/Crypt/RandPasswd.pm. Ok. TODO: Build-require `perl-generators' for autogenerating binary dependencies for the binary package. All tests pass. Ok. $ rpmlint perl-Crypt-RandPasswd.spec ../SRPMS/perl-Crypt-RandPasswd-0.06-1.fc25.src.rpm ../RPMS/noarch/perl-Crypt-RandPasswd-0.06-1.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Crypt-RandPasswd-0.06-1.fc25.noarch.rpm drwxr-xr-x 2 root root 0 May 9 16:48 /usr/share/doc/perl-Crypt-RandPasswd -rw-r--r-- 1 root root 823 May 23 2014 /usr/share/doc/perl-Crypt-RandPasswd/Changes -rw-r--r-- 1 root root 935 Apr 7 2013 /usr/share/doc/perl-Crypt-RandPasswd/README -rw-r--r-- 1 root root 3570 May 9 16:48 /usr/share/man/man3/Crypt::RandPasswd.3pm.gz drwxr-xr-x 2 root root 0 May 9 16:48 /usr/share/perl5/vendor_perl/Crypt -rw-r--r-- 1 root root 96767 May 23 2014 /usr/share/perl5/vendor_perl/Crypt/RandPasswd.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-RandPasswd-0.06-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.22.2) 1 perl(:VERSION) >= 5.6.0 1 perl(constant) 1 perl(Getopt::Long) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Crypt-RandPasswd-0.06-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(Crypt::RandPasswd) = 0.06 1 perl-Crypt-RandPasswd = 0.06-1.fc25 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Crypt-RandPasswd-0.06-1.fc25.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13981533). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx