https://bugzilla.redhat.com/show_bug.cgi?id=1327989 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK + license is OK (BSD) + license file is present, %license is used + latest version + builds and installs OK + provides/requires look sane + python_provide macro is used + no scriptlets present or necessary I see one issue: python2-subpackage has a bunch of python2 .pyc files (in site-packages/jypyter_client/ and site-packages/jypyter_client/blocking. They don't cause an actual problem, since python3 uses __pycache__/ and will not even look at those files, but still it's rather inelegant. (I think they might be created when sphinx is run. My suggestion would be to simply use find to nuke all .pyc files in %buildroot at the end of %install. rpm will generate them anyway). Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx