https://bugzilla.redhat.com/show_bug.cgi?id=1333533 Michael Cullen <michael@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@xxxxxxxxxxxxxxxxx --- Comment #1 from Michael Cullen <michael@xxxxxxxxxxxxxxxxx> --- Note: I am not (yet) a packager so this should be considered an informal review/comment TL;DR version: * Provide a srpm so fedora-review works * Fix your spec file so that it actually builds Longer version: You'll probably be more likely to get reviews on this if you provide a "plain" spec link and an SRPM package. This is so the fedora-review tools works nicely. That said, eyeballing the spec file I have a couple of comments: * You might want to consider forming the version number from the date of the git sha as per https://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease * once I created a srpm file, it didn't build for me. cd: bubblewrap-0: No such file or directory This will be because the tarball extracts to a folder named bubblewrap-66d12bb23b04e201c5846e325f0b10930ed802f8 so you need %autosetup -Sgit -n %{name}-%{commit0} rather than %autosetup -Sgit -n %{name}-%{version} then, I get this error: cp -pr COPYING /builddir/build/BUILDROOT/bubblewrap-0-1.fc23.x86_64/usr/share/licenses/bubblewrap cp: cannot stat 'COPYING': No such file or directory no doubt because the COPYING file doesn't exist until two commits later. So now I have a package. rpmlint takes exception at a couple of things: bubblewrap.src: W: spelling-error %description -l en_US usr -> use, us, user bubblewrap.src: W: spelling-error %description -l en_US bwrap -> wrap, b wrap bubblewrap.src: W: spelling-error %description -l en_US setuid -> setup bubblewrap.src: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces bubblewrap.src: E: no-changelogname-tag bubblewrap.x86_64: W: spelling-error %description -l en_US setuid -> setup bubblewrap.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces bubblewrap.x86_64: E: no-changelogname-tag bubblewrap.x86_64: E: non-executable-script /usr/share/bash-completion/completions/bwrap 644 /bin/bash bubblewrap-debuginfo.x86_64: E: no-changelogname-tag 3 packages and 0 specfiles checked; 4 errors, 6 warnings. Ignoring the spelling warnings (which are not correct) we have two problems: bubblewrap.x86_64: E: no-changelogname-tag bubblewrap.x86_64: E: non-executable-script /usr/share/bash-completion The first is because you have no changelog, the second is because the conditional around setting the file permissions on RHEL also seems to be needed on Fedora. (why is this conditional?) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx