https://bugzilla.redhat.com/show_bug.cgi?id=1314865 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> --- $ rpmlint booth.spec ../SRPMS/booth-1.0-2.eb4256a.git.fc25.src.rpm ../RPMS/{noarch,x86_64}/booth-*-2.* booth.spec:252: E: hardcoded-library-path in /usr/lib/ocf/resource.d/pacemaker/booth-site booth.spec:253: E: hardcoded-library-path in /usr/lib/ocf/lib/booth booth.spec:254: E: hardcoded-library-path in /usr/lib/ocf/lib/booth/geo_attr.sh booth.spec:259: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth booth.spec:260: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/geostore booth.spec:270: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/sharedrsc booth.src:252: E: hardcoded-library-path in /usr/lib/ocf/resource.d/pacemaker/booth-site booth.src:253: E: hardcoded-library-path in /usr/lib/ocf/lib/booth booth.src:254: E: hardcoded-library-path in /usr/lib/ocf/lib/booth/geo_attr.sh booth.src:259: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth booth.src:260: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/geostore booth.src:270: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/sharedrsc booth-arbitrator.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti booth-arbitrator.noarch: W: no-documentation booth-site.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti booth-site.noarch: W: only-non-binary-in-usr-lib booth-site.noarch: W: dangling-symlink /usr/sbin/geostore /usr/sbin/boothd booth-test.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti booth-test.noarch: W: only-non-binary-in-usr-lib booth-test.noarch: W: dangling-symlink /usr/share/booth/tests/src/boothd /usr/sbin/boothd booth.x86_64: E: no-binary booth.x86_64: W: no-documentation booth-core.x86_64: W: spelling-error Summary(en_US) executables -> executable, executable s, executrices booth-core.x86_64: W: spelling-error %description -l en_US executables -> executable, executable s, executrices booth-core.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti 7 packages and 1 specfiles checked; 13 errors, 12 warnings. rpmlint is Ok. > FIX: booth-arbitrator should package transaction scripts and require systemd $ rpm -q --requires -p ../RPMS/noarch/booth-arbitrator-1.0-2.eb4256a.git.fc25.noarch.rpm |sort -f | uniq -c 3 /bin/sh 1 booth-core = 1.0-2.eb4256a.git.fc25 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 3 systemd $ rpm -q --scripts -p ../RPMS/noarch/booth-arbitrator-1.0-2.eb4256a.git.fc25.noarch.rpm postinstall scriptlet (using /bin/sh): if [ $1 -eq 1 ] ; then # Initial installation systemctl --no-reload preset booth@.service booth-arbitrator.service >/dev/null 2>&1 || : fi preuninstall scriptlet (using /bin/sh): if [ $1 -eq 0 ] ; then # Package removal, not upgrade systemctl --no-reload disable --now booth@.service booth-arbitrator.service > /dev/null 2>&1 || : fi postuninstall scriptlet (using /bin/sh): if [ $1 -ge 1 ] ; then # Package upgrade, not uninstall systemctl try-restart booth@.service booth-arbitrator.service >/dev/null 2>&1 || : fi Ok. > FIX: Packaging COPYING by "%license %{_pkgdocdir}/COPYING" does not work. $ rpm -q -l -p ../RPMS/x86_64/booth-core-1.0-2.eb4256a.git.fc25.x86_64.rpm /etc/booth /usr/sbin/booth /usr/sbin/booth-keygen /usr/sbin/boothd /usr/share/doc/booth/AUTHORS /usr/share/doc/booth/ChangeLog /usr/share/doc/booth/README /usr/share/doc/booth/booth.conf.example /usr/share/licenses/booth-core /usr/share/licenses/booth-core/COPYING /usr/share/man/man8/booth-keygen.8.gz /usr/share/man/man8/booth.8.gz /usr/share/man/man8/boothd.8.gz Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13942807). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx