https://bugzilla.redhat.com/show_bug.cgi?id=1233240 --- Comment #9 from Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> --- Spec URL: https://thofmann.fedorapeople.org/orocos-bfl.spec SRPM URL: https://thofmann.fedorapeople.org/orocos-bfl-0.8.99-5.20160503gitc1b18e3.fc23.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13930772 Thank you for your comments. (In reply to Jerry James from comment #8) > Issues > ====== > 1. In multiple licensing scenarios, the package must contain a comment > explaining the breakdown: see > > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Multiple_Licensing_Scenarios > > This can be accomplished in several ways; see the link for some ideas. Thanks for the link, I didn't know that. I actually had to change the license again after checking all files manually. All the GPLv2+ licensed files are tests which are not shipped. Also, the exception is on GPLv2 licensed files, not on LGPLv2+ licensed files. Now it should be correct and I also added an explanation why they use multiple licenses. > > 3. The license file is not installed if only the -doc subpackage is > installed. Fixed. > > 4. If you are concerned about the quality of the documentation, there are a > few > steps you could take to improve it: > a. Replace "BuildRequires: doxygen" with "BuildRequires: doxygen-latex" > b. Add "BuildRequires: ghostscript-core" > c. Change the definition of INCLUDE_PATH in Doxyfile from the empty string > to /usr/include/boost. Unfortunately, then doxygen can't find the > standard header files, so you have to add the default g++ include paths > to INCLUDE_PATH as well. You can get these by running > > cpp -x c++ -v < /dev/null > > and looking at the lines of output between "#include <...> search > starts > here:" and "End of search list." For example, you could do this just > before running doxygen: > > includedirs=$(cpp -x c++ -v < /dev/null 2>&1 | sed -e '1,/#include > <\.\.\.> search/d' -e '/End of search list/,$d' | tr '\n' ' ') > sed -i "s|INCLUDE_PATH[[:blank:]]*= |&/usr/include/boost > $includedirs|" Doxyfile Thanks, I did exactly that. > > 5. I wonder why one test failure on i386 warrants not running the tests for > that platform, but one test failure on ARM warrants not building the > package > at all for that platform. Can you explain? (The explanation should > probably go into a comment in the spec file.) The test failure on i686 is merely a rounding issue: > 2: pdf_test.cpp:1135:Assertion > 2: Test name: PdfTest::testMixture > 2: equality assertion failed > 2: - Expected: 0.0590505944295115 > 2: - Actual : 0.0590505944295115 Therefore I assume it's actually working, all other tests pass. On the other hand, on ARM the test result is completely off: > 5: model_test.cpp:99:Assertion > 5: Test name: ModelTest::testDiscreteSystemModel > 5: equality assertion failed > 5: - Expected: 0.98 > 5: - Actual : 0.005 To me, this looks like a bug and I cannot say if it's working on ARM. Therefore, I excluded ARM. I also added more detailed explanations to the Spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx