https://bugzilla.redhat.com/show_bug.cgi?id=1314865 --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source URL is usable. Ok. Source archive is orignal (SHA-256: 66420985bee695d9b9e77d8f6d26f6400c29f492f3df5270aadf6452f918bf09). Ok. License verified from COPYING and various source files. Ok. TODO: Source files docs/geostore.8.txt and docs/boothd.8.txt and thus manual pages geostore(8) and boothd(8) still declare GPL+. It would be great to notify the upstream. All tests pass. Ok. $ rpmlint booth.spec ../SRPMS/booth-1.0-1.eb4256a.git.fc25.src.rpm ../RPMS/{noarch,x86_64}/booth-* booth.spec:241: E: hardcoded-library-path in /usr/lib/ocf/resource.d/pacemaker/booth-site booth.spec:242: E: hardcoded-library-path in /usr/lib/ocf/lib/booth booth.spec:243: E: hardcoded-library-path in /usr/lib/ocf/lib/booth/geo_attr.sh booth.spec:248: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth booth.spec:249: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/geostore booth.spec:259: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/sharedrsc booth.src:241: E: hardcoded-library-path in /usr/lib/ocf/resource.d/pacemaker/booth-site booth.src:242: E: hardcoded-library-path in /usr/lib/ocf/lib/booth booth.src:243: E: hardcoded-library-path in /usr/lib/ocf/lib/booth/geo_attr.sh booth.src:248: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth booth.src:249: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/geostore booth.src:259: E: hardcoded-library-path in /usr/lib/ocf/resource.d/booth/sharedrsc booth-arbitrator.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti booth-arbitrator.noarch: W: no-documentation booth-site.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti booth-site.noarch: W: only-non-binary-in-usr-lib booth-site.noarch: W: dangling-symlink /usr/sbin/geostore /usr/sbin/boothd booth-test.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti booth-test.noarch: W: only-non-binary-in-usr-lib booth-test.noarch: W: dangling-symlink /usr/share/booth/tests/src/boothd /usr/sbin/boothd booth.x86_64: E: no-binary booth.x86_64: W: no-documentation booth-core.x86_64: W: spelling-error Summary(en_US) executables -> executable, executable s, executrices booth-core.x86_64: W: spelling-error %description -l en_US executables -> executable, executable s, executrices booth-core.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti 7 packages and 1 specfiles checked; 13 errors, 12 warnings. rpmlint is Ok. $ rpm -q -l -p ../RPMS/noarch/booth-arbitrator-1.0-1.eb4256a.git.fc25.noarch.rpm /usr/lib/systemd/system/booth-arbitrator.service /usr/lib/systemd/system/booth@.service $ rpm -q --requires -p ../RPMS/noarch/booth-arbitrator-1.0-1.eb4256a.git.fc25.noarch.rpm | sort -f | uniq -c 1 booth-core = 1.0-1.eb4256a.git.fc25 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: booth-arbitrator should package transaction scripts and require systemd <https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd>. # rpm -i --excludedocs ~test/rpmbuild/RPMS/x86_64/booth-core-1.0-1.eb4256a.git.fc25.x86_64.rpm # rpm -ql booth-core /etc/booth /usr/sbin/booth /usr/sbin/booth-keygen /usr/sbin/boothd /usr/share/doc/booth/AUTHORS /usr/share/doc/booth/COPYING /usr/share/doc/booth/ChangeLog /usr/share/doc/booth/README /usr/share/doc/booth/booth.conf.example /usr/share/man/man8/booth-keygen.8.gz /usr/share/man/man8/booth.8.gz /usr/share/man/man8/boothd.8.gz # LC_ALL=en_US.UTF-8 stat /usr/share/doc/booth/COPYING stat: cannot stat '/usr/share/doc/booth/COPYING': No such file or directory FIX: Packaging COPYING by "%license %{_pkgdocdir}/COPYING" does not work. It still marks COPYING as a documentation and removes the license file if documentation is excluded. Try package it by relative path or report a bug against rpm. Otherwise file layout, permissions, and dependencies are Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13903771). Ok. Please correct the `FIX' issues and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx