Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qgis - A user friendly Open Source Geographic Information System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241403 ------- Additional Comments From silfreed@xxxxxxxxxxxx 2007-06-27 13:18 EST ------- I'll have 0.8.1-4 up shortly; it's building in mock right now - I need to test the desktop file and upload it. I'll reply when its done. (In reply to comment #30) > ? Dependency > - By the way, Does qgis-grass not depend on grass? > (currently while qgis depends on grass-libs, > it does not require grass itself. This is a > QUESTION, not blocker) AFAICT, qgis-grass should not depend on grass, just grass-libs. And can you confirm that qgis doesn't depend on grass-libs? It doesn't on my box, just wanted to make sure that was a typo. > ? %check > - tarball contains tests/ directory. Can qgis do > some test program like "make check" at build stage? > If so, add %check stage and do some check program > in %check stage. I can't get the tests to compile; it errors out with: g++ -o tests -L/usr/lib/qt-3.3/lib -lqt-mt -lXext -lX11 -lm /usr/lib/gcc/i386-redhat-linux/4.1.1/../../../crt1.o: In function `_start': (.text+0x18): undefined reference to `main' collect2: ld returned 1 exit status make: *** [tests] Error 1 > ? Files with white spaces > - Just a question: some files have names with white spaces. > Is it okay? These are provided from upstream, so I'll work with them to get any problems here worked out. > Well, as this is a sponsor needed tickets: ..snip.. > Usually there are two ways to show this. > A. submit other review requests with enough quality. I have some other packages that I'm sitting on; I think I'll be submitting qtpfsgui for inclusion; I'll post the bug id here once I have it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review