https://bugzilla.redhat.com/show_bug.cgi?id=1328041 --- Comment #2 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Antonio Trande from comment #1) > > ===== Issues ===== > > - Compile involves code released under BSD license (src/hmac) and > LGPLv2+ (src/ApeTag.cpp src/ApeTag.h src/TagInfo.cpp src/TagInfo.h). done > - Default compiler flags are not honored with 'c++', only with 'cc'. > See build log. > done > - appdata file is not edited according to the Fedora guidelines and points to > screenshot from different operating systems. > See https://fedoraproject.org/wiki/Packaging:AppData > added patch, if this is ok, i will forward the patch to upstream. > - Your package does not install icons into one of the subdirectories in > %{_datadir}/icons/; scriptlets are useless. > https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging: > ScriptletSnippets#Icon_Cache > done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/musicqueue.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/musicqueue-0.4.6-1.gitd2d8824.fc24.src.rpm %changelog * Tue May 03 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.4.6-1.gitd2d8824 - updat to 0.4.6 - added license BSD and LGPLv2+ to license tag - added -DCMAKE_C_FLAGS="%%{optflags}" - added %%{name}-appdata.patch - dropped scriptlets for installing %%{_datadir}/icons/ - spec file cleanup rpmlint: Checking: musicqueue-0.4.6-1.gitd2d8824.fc25.x86_64.rpm musicqueue-debuginfo-0.4.6-1.gitd2d8824.fc25.x86_64.rpm musicqueue-0.4.6-1.gitd2d8824.fc25.src.rpm musicqueue.x86_64: W: spelling-error Summary(en_US) orgainizer -> organizer, organize musicqueue.x86_64: W: spelling-error %description -l en_US orgainizer -> organizer, organize musicqueue.x86_64: W: spelling-error %description -l en_US revison -> revision musicqueue.x86_64: W: spelling-error %description -l en_US podcasts -> podcast, pod casts, pod-casts musicqueue.x86_64: W: no-manual-page-for-binary musicqueue musicqueue.src: W: spelling-error Summary(en_US) orgainizer -> organizer, organize musicqueue.src: W: spelling-error %description -l en_US orgainizer -> organizer, organize musicqueue.src: W: spelling-error %description -l en_US revison -> revision musicqueue.src: W: spelling-error %description -l en_US podcasts -> podcast, pod casts, pod-casts musicqueue.src:29: W: unversioned-explicit-provides bundled(md5-polstra) 3 packages and 0 specfiles checked; 0 errors, 10 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx