[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1330858



--- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> ---
> - Dist tag is present.

Please use "%{?dist}" in place of "%{dist}" in the Release field.

> - gtk-update-icon-cache is invoked in %postun and %posttrans if package
>   contains icons.
>   Note: icons in numix-icon-theme

The icon cache generation is missing, please look at the following link:

https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache

Apply the examples exactly as they are, simply repeating the snippets for the
themes installed (Numix adn Numix-Light) in place of "hicolor".

> [!]: Changelog in prescribed format.
> numix-icon-theme.noarch: W: incoherent-version-in-changelog 0.1.0-8 ['0.1.0-8.git101307f.fc23', '0.1.0-8.git101307f']

You should have exactly the same name-version-release tags in the changelog as
the package that you are generating. That is, in this case: 0.1.0-8.git101307f

Please note that actually (next time) when you update the spec file with
"rpmdev-bumpspec" it will actually put the correct tag in the changelog as
required.

> [!]: Requires correct, justified where necessary.

The directory %{_datadir}/icons is not owned by your package, please add
"filesystem" as requirement. It's always installed, but better be safe than
sorry.

$ rpm -qf /usr/share/icons/
filesystem-3.2-37.fc24.x86_64



Also, if you're not planning to support RHEL 6 please remove the "Group:" tag
(not required but not mandatory to be removed).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]